skpkg: update names to comply with skpkg standards#31
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 75.67% 75.67%
=======================================
Files 3 3
Lines 37 37
=======================================
Hits 28 28
Misses 9 9 🚀 New features to boost your workflow:
|
|
@sbillinge ready for merge. docs didn't deploy because this naming convention change |
|
I think this will conflict with @Tieqiong's PR so I will hold off merging this for now. Let's leave it open though until we are sure and close it after that one merges successfully. |
|
@sbillinge okay, I'll keep an eye on that one and ping you to merge once Tieqiongs PR goes through |
|
Oh I just looked at that PR and it looks like Tieqiong handled this so this PR is probably unnecessary but I'll leave it for now |
|
great! Let me know when current cmi on CF passes all the tutorials. When @Tieqiong's passes CI I can merge that and we go again. |
|
@sbillinge the CI is passing, it's just codecov/project failing because the coverage dropped by 25% (due to me removing the skpkg template test)... |
ah, ok. |
|
Closing as complete by tieqiongs PR |
changed doc to docs and replaced underscores with hyphens in code of conduct.